Skip to content

Feature A — Wait for completed required checks (#307 auto-approve) - #1250

Merged
oxa-orchestrator[bot] merged 21 commits into
mainfrom
agent/307-board-review-policy
Nov 18, 2026
Merged

oxa-orchestrator[bot] merged 21 commits into
mainfrom
agent/307-board-review-policy

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Feature A (#1214 and #1017), #307 auto-approve row. Tier T2.

The read-only review-policy qualification found an actual required CheckRun on #1113 with status IN_PROGRESS and a retained SUCCESS conclusion. GitHub lists it as in progress. The native Reader now reads a CheckRun conclusion only after completion. Status contexts continue to use their own state. The existing policy, request deduplication, acquisition limits and queue evidence stay in force. Exact live job

The real shadow CLI regression in oxa-cli failed before the fix at a1eb623c0a5035947de0790980bb982b4193b274: the active required check produced ready where wait_required_ci was expected. Hosted before run

Formatting and diff checks passed. Fixed head 402f6d156da35e12b938e965d8161211263a9d23 passed the hosted oxa-cli lane on x64 and ARM64 (fixed-head run).

The ready-state checks and the authenticated Codex review cleared at the fixed head. The merge-group checks passed and the PR landed at e900c21fa24444251126469fa4fee70f0f5bbb24.

oxa-agent added 21 commits November 17, 2026 20:52
…w-policy

# Conflicts:
#	oxa/oxa-work/src/shadow.rs
…w-policy

# Conflicts:
#	oxa/oxa-cli/src/work_board.rs
#	oxa/oxa-work/tests/board_controls.rs
…w-policy

# Conflicts:
#	oxa/oxa-work/src/board/review.rs
#	oxa/oxa-work/tests/board_review.rs
@oxa-agent
oxa-agent Bot marked this pull request as ready for review November 18, 2026 00:40
@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T00:46:35.871244Z 402f6d1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 402f6d156d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit e900c21 Nov 18, 2026
51 checks passed
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/307-board-review-policy branch November 18, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant